-
Notifications
You must be signed in to change notification settings - Fork 24
Silence ostruct warnings #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fwiw I've already got the Rails 8.1 upgrade done: #632 |
|
@G-Rath Just checked on #632 branch and the ostruct warning is still there so upgrading Rails didn't fix it I'll update this PR to reflect that. |
|
@eoinkelly what variants are you generating with? this doesn't show up in our CI because we run against the lowest version of Ruby we aim to support, and I didn't see this in the Rails app I generated about a week ago. On my other Rails project that also doesn't have this, I have a feeling that #530 might resolve this, which is something I've been meaning to PR anyway (I did it on the aforementioned project, and it actually resulted in a speed increase!) |
|
I generated using the config from this repo root (basically the default config) and Ruby 3.4.8. Nothing in this PR is urgent so I'm fine if you want to wait and see how it shakes out @G-Rath |
fwiw I'm wrong, we apparently use
With this new found knowledge, I can also say that #640 does resolve this 🎉 |

Changes
target_versions.ymlfile for supported Rails version, avoiding having the supported Rails version hard-coded in an easy to forget placeostructgem to theGemfileto silence a warning from Ruby 3.4.8 about ostruct being removed from default gems in Ruby 4.It's possible Rails 8.1 solves this for us but I think an 8.1 upgrade should be it's own PR so this seems like an ok stop-gapUpdate: Rails 8.1 doesn't silence this for us.