Skip to content

Conversation

ridz1208
Copy link
Collaborator

Brief summary of changes

Just some fixes that were necessary on CBIG to be able to build the dictionary

  1. ignore .meta fields for LINST files
  2. re-add DATA ENTRY common filed to all instruments
  3. make the script runnable from anywhere

TODO if I get time make the script check if the instrument is an instance of the Instrument class rather than pattern matching on 'extends NDB_BVL_Instrument'

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

break;

//for HTML_QuickForm versions of standard HTML Form Elements...
case "jsondata":
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffersoncasimir did we have other headers toignore here?

@driusan
Copy link
Collaborator

driusan commented Sep 23, 2025

@ridz1208 Failing tests

@nicolasbrossard
Copy link
Contributor

Tested on my VM:

  1. jsondata and norules ignored
  2. Data_entry field added to data dictionary.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants