Skip to content

[issue_tracker] Fix typo #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CamilleBeau
Copy link
Collaborator

@CamilleBeau CamilleBeau commented Apr 16, 2025

Brief summary of changes

This PR modifies the code in modules/issue_tracker/php/edit.class.inc where the drop-down values are set to accommodate for the new permissions that were added in 27. With this code, the "close" option is added to the statuses drop-down in cases where a user has the appropriate permission to close the current issue, and it is not added otherwise.

All of the changes that were previously done in this PR are now done and merged in #9842. Now this PR only fixes a typo in variable names.

  • Have you updated related documentation?

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves #NO ISSUE

@CamilleBeau CamilleBeau added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Apr 16, 2025
@CamilleBeau CamilleBeau added this to the 27.0.0 milestone Apr 16, 2025
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: issue_tracker PR or issue related to issue tracker module labels Apr 16, 2025
@CamilleBeau CamilleBeau removed the Language: PHP PR or issue that update PHP code label Apr 16, 2025
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Apr 16, 2025
@skarya22
Copy link
Contributor

@CamilleBeau update description to have more details

@CamilleBeau CamilleBeau changed the title [issue_tracker] Fix typo & cleanup close permission [issue_tracker] Fix typo & Cleanup close permission May 13, 2025
@adamdaudrich
Copy link
Collaborator

LGTM

@CamilleBeau CamilleBeau changed the base branch from main to 27.0-release June 17, 2025 13:45
@CamilleBeau CamilleBeau changed the title [issue_tracker] Fix typo & Cleanup close permission [issue_tracker] Fix typo Jun 17, 2025
@driusan driusan merged commit a98e9b6 into aces:27.0-release Jun 18, 2025
20 checks passed
SKADE2303 pushed a commit to SKADE2303/Loris that referenced this pull request Jul 10, 2025
Fix variable name in issue tracker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: PHP PR or issue that update PHP code Module: issue_tracker PR or issue related to issue tracker module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants