[help_editor] Translate help editor module #10009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 12, 2025 08:28
github-actions
bot
added
Language: Javascript
SKADE2303
added
Event: GSOC
driusan
reviewed
Sep 12, 2025
| id="save-help" | ||
| name="fire_away" | ||
| value="Save" | ||
| value={t('Save', {ns: 'help_editor'})} |
There was a problem hiding this comment.
Not sure if this exists in the loris namespace but it probably should. I'd be surprised if this was the only place we said "Save"
There was a problem hiding this comment.
It's not there.. but agree, this should be in loris.po
driusan
reviewed
Sep 12, 2025
| // XXX: Replace this with a UI component for 500 errors. | ||
| if (this.state.error) { | ||
| return <h3>An error occured while loading the page.</h3>; | ||
| return <h3>{t('An error occured while loading the page.', |
There was a problem hiding this comment.
yes,
please point to the correct namespace @SKADE2303
racostas
added
the
State: Needs work
SKADE2303
removed
the
State: Needs work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module help_editor to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)