Skip to content

Improve BIDS importer #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Improve BIDS importer #1334

wants to merge 12 commits into from

Conversation

@MaximeBICMTL
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL commented Nov 16, 2025 •
edited
Loading

Builds on #1325.

Description

Improve the post-refactor BIDS importer code quality with various changes.

Details

Best to review commit by commit:

  • Commit 1: Rename some types from BidsXyz to BIDSXyz to better match Python naming conventions.
  • Commit 2: Adopt Path instead of str in the BIDS importer.

maximemulder and others added 7 commits November 16, 2025 05:53
@maximemulder @MaximeBICMTL
incremental bids importer
c74d140 
bids session dataclass

bids participants dataclass

factorize combination iteration

fix layout ignore

skip files already inserted

wip

fix mri path join

rebase commit

migrate to new database abstraction

rewrite

optional dataset_description.json

return an error on unknown scan types

fix wrong counter and memory use
@MaximeBICMTL
fix eeg path concatenation
1239f53
@MaximeBICMTL
fix cli options
6448a6c
@MaximeBICMTL
make profile cli argument optional
d16441e
@MaximeBICMTL
add missing candidate and session fields
608f36b
@MaximeBICMTL
fix print statement
55d4303
@MaximeBICMTL
use lists instead of tuples for eeg paths
2af7b5b
@github-actions github-actions bot added the Language: Python Issue or PR related to the Python codebase label Nov 16, 2025
@MaximeBICMTL MaximeBICMTL added Pipeline: BIDS importer PR or issue related to the BIDS importer Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test labels Nov 16, 2025
@MaximeBICMTL MaximeBICMTL marked this pull request as draft November 17, 2025 07:12
@MaximeBICMTL
Copy link
Contributor Author

MaximeBICMTL commented Dec 5, 2025

This will be integrated and merged into #1335.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test Language: Python Issue or PR related to the Python codebase Pipeline: BIDS importer PR or issue related to the BIDS importer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaximeBICMTL @maximemulder