Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goggles - Add draw overlay setting #10484

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Goggles - Add draw overlay setting #10484

wants to merge 4 commits into from

Conversation

SpicyBagpipes
Copy link
Contributor

@SpicyBagpipes SpicyBagpipes commented Nov 7, 2024 •
edited
Loading

When merged this pull request will:

  • Title

Redo of 9896

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes SpicyBagpipes mentioned this pull request Nov 7, 2024
Closed
@SpicyBagpipes
Copy link
Contributor Author

Easier to redo from scratch based on comments from previous PR

@veteran29
Copy link
Member

Why is it named draw overlay if it affects the effects only.

@LinkIsGrim LinkIsGrim added the kind/setting Release Notes: **SETTINGS:** label Nov 7, 2024
@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Nov 7, 2024
@SpicyBagpipes
Copy link
Contributor Author

Why is it named draw overlay if it affects the effects only.

My bad, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SpicyBagpipes @veteran29 @LinkIsGrim