Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-markdown-editor): direct page break - #276 #288

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

d-e-v-esh
Copy link
Contributor

@d-e-v-esh d-e-v-esh commented Mar 10, 2021

Signed-off-by: d-e-v-esh [email protected]

Closes #259

Beforehand, doing --- did not do anything and kept the text as it is but doing that now inserts a page break.
This will only insert a page break on a new line.

Changes

  • Added a new file withText that will handle all the new shortcuts that will be created from now based on just entering text.

Flags

Screenshots or Video

ymDYJTesqe

QxRmrXqsAL

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instruction

@mttrbrts mttrbrts requested a review from dselman March 12, 2021 10:55
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs investigation by @dselman.

@jolanglinais
Copy link
Member

Pinging @dselman on this PR/Issue. Note that #263 should be resolved with #270

@jolanglinais
Copy link
Member

Personally, this looks good to me and a good approach. So I agree with you in your comment #321 (comment) to build on this for more future shortcuts.

@jolanglinais jolanglinais merged commit 0667d02 into accordproject:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct Page Break Does Not Work
2 participants