Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertHeadingbreak Bug Fixed #261

Closed
wants to merge 0 commits into from
Closed

Conversation

d-e-v-esh
Copy link
Contributor

@d-e-v-esh d-e-v-esh commented Feb 23, 2021

Closes #

  • Before: The cursor would jump one line above when we would press enter from the beginning of any heading text

r91hU4x2ti

  • Now: It works as expected now and stays in the same line

CAeWDpfbXi

Changes

+ Transforms.move(editor, { distance: 1, unit: 'character' })

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.

  • Vital features and changes captured in unit and/or integration tests

  • Commits messages follow AP format

  • Extend the documentation, if necessary

  • Merging to master from fork:branchname

  • Manual accessibility test performed

    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: Devesh [email protected]

Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cleanup the commits, PR template, and sign the DCO?

@d-e-v-esh
Copy link
Contributor Author

@irmerk Hey I cleaned up the commits. I apologize for being a little sloppy. This is very new for me but I'll pick up speed quickly, don't worry. Is anything wrong with the PR Template or anything else?

@jolanglinais
Copy link
Member

I think you'll still want to fix the commit and add the DCO signoff (https://github.com/accordproject/techdocs/blob/master/CONTRIBUTING.md#-pull-request-submission-guidelines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants