Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct Page Break Does Not Work #259

Closed
d-e-v-esh opened this issue Feb 23, 2021 · 4 comments · Fixed by #288
Closed

Direct Page Break Does Not Work #259

d-e-v-esh opened this issue Feb 23, 2021 · 4 comments · Fixed by #288

Comments

@d-e-v-esh
Copy link
Contributor

Bug Report 🐛

When we click on the page-break icon, it adds --- in the markdown panel as the page break. But when we directly write --- on the editor then page break doesn't work.

Expected Behavior

Writing --- should add a page break on the editor

Current Behavior

Writing --- doesn't create a page break. It just writes it as it is.

Possible Solution

It would be very convenient if the user doesn't have to touch the mouse and can directly add a page break from the keyboard by entering ---.

If --- gets entered in the middle of the line then the cursor should jump to the next line and make a page break. If the user did this by mistake then he can just backspace once, and we would put him where he was before the page break occurred.

Steps to Reproduce

  1. Write --- on the editor

Desktop

  • OS: Windows 10
  • Browser: Chrome
  • Version 88.0.4324.182 (Official Build) (64-bit)
@dselman
Copy link
Contributor

dselman commented Feb 23, 2021

I've marked this as an enhancement, because in general markdown syntax is not converted to formatted text. You could consider whether it would be more appropriate to add a keyboard hotkey for this instead (consistent with CTRL-B etc used for formatting). Perhaps looking at GDocs or Office 365 will give some inspiration?

@d-e-v-esh
Copy link
Contributor Author

@dselman That is very true. But there is already a keyboard shortcut assigned to that task. When you go and hover over the Page Break icon, it will show that the shortcut for that is ctrl + enter but that is not working either for some reason. I'm looking into it for quite some time, I will try to find a solution if I can.

@jolanglinais
Copy link
Member

Pinging @Michael-Grover on this.

@Michael-Grover
Copy link

I agree with Dan. I think fixing the shortcut is a higher priority than this enhancement. I created an issue for the shortcut bug: #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants