Persist dark/light mode across page reloads #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shiva <[email protected]>
|
@DianaLease could you review this PR ? |
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: shiva <[email protected]>
sanketshevkar
requested changes
Apr 7, 2025
src/components/ToggleDarkMode.tsx
Outdated
| @@ -8,8 +8,9 @@ const ToggleDarkMode: React.FC = () => { | |||
| const [isDarkMode, setIsDarkMode] = useState(backgroundColor === "#121212"); | |||
|
|
|||
| useEffect(() => { | |||
| setIsDarkMode(backgroundColor === "#121212"); | |||
| }, [backgroundColor]); | |||
| const savedTheme = localStorage.getItem('theme'); | |||
There was a problem hiding this comment.
Can't we just get this before initialising the state variable above? We can get rid of this useState?
There was a problem hiding this comment.
resolved @sanketshevkar
src/store/store.ts
Outdated
| const savedTheme = localStorage.getItem('theme'); | ||
| if (savedTheme === 'dark') { | ||
| set(() => ({ | ||
| backgroundColor: '#121212', |
There was a problem hiding this comment.
Can we please move all these string values to a constants file? We can reuse as variables across the app.
There was a problem hiding this comment.
resolved @sanketshevkar
Signed-off-by: shiva <[email protected]>
|
Sry @sanketshevkar for the late response..caught up with semester exams |
Signed-off-by: shiva <[email protected]>
|
@sanketshevkar @DianaLease @dselman ..could you review the PR when you find time ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336
Persist Dark/Light Mode Across Page Reloads
Changes
Flags
Screenshots or Video
Author Checklist
--signoffoption of git commit.mainfromfork:branchname