Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roman and alphanumeric list feature #590

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

subhajit20
Copy link

@subhajit20 subhajit20 commented Mar 14, 2024

Closes accordproject/template-playground#10

Added roman and alphanumeric list feature

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Subhajit Ghosh <[email protected]>
@subhajit20
Copy link
Author

I have only added the Roman list feature as of now. Any suggestion for an alphanumeric list @dselman

Signed-off-by: Subhajit Ghosh <[email protected]>
Signed-off-by: Subhajit Ghosh <[email protected]>
@subhajit20
Copy link
Author

hey @sanketshevkar @DianaLease can you guys review this pr and give me a feedback ?

Signed-off-by: Subhajit Ghosh <[email protected]>
@sanketshevkar
Copy link
Member

Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks.

@subhajit20
Copy link
Author

Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks.

Have one confusion that in the issue @dselman mentioned the markdown should have roman and alphanumeric
list ... here what does markdown mean like there are multiple markdown packages I can see in the repo ... so which one should have that feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List formatting: roman and alphanumeric
2 participants