feat(markdown-docx): add variable transformer - #397 #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helpers and rule Add the transformation logic Add the test for above Signed-off-by: k-kumar-01 <[email protected]>
algomaster99
suggested changes
Jun 16, 2021
There was a problem hiding this comment.
Minor changes, then we would be good to go.
I also want you to keep a mental note that the CiceroMarkToOOXML transformer should also return the counter object as this would be used in MS Word Add-in. If we don't return it, we would have to parse the OOXML string in the add-in to generate it, which is very prone to error. Since this PR works well on its own, you can do that in a separate PR but first, just understand why the counter variable is important.
| <w:rPr> | ||
| <w:color w:val="000000"/> | ||
| <w:sz w:val="24"/> | ||
| <w:highlight w:val="green"/> |
There was a problem hiding this comment.
Remove this for now. We will discuss later if we want to highlight variables or now.
Remove highlight Remove default colour Signed-off-by: k-kumar-01 <[email protected]>
|
@algomaster99 |
Merged
5 tasks
algomaster99
pushed a commit
that referenced
this pull request
Jun 17, 2021
Signed-off-by: k-kumar-01 <[email protected]>
algomaster99
pushed a commit
that referenced
this pull request
Jun 17, 2021
Signed-off-by: k-kumar-01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-kumar-01 [email protected]
Partial fix #397
Adds the roundtrip transformation for
variable.Changes
Author Checklist
--signoffoption of git commit.masterfromfork:branchname