Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent redefinition of imported types in model validation (#871) #902

Closed
wants to merge 1 commit into from
Closed

Fix: Prevent redefinition of imported types in model validation (#871) #902

wants to merge 1 commit into from

Conversation

yashsaraswat2004
Copy link

Closes #871

Changes

  • Added validation logic to check for name conflicts between local declarations and imported types.
  • Updated uniqueNames set to include imported types and prevent redefinition.

Flags

  • Ensure validation does not impact performance significantly.
  • Review the handling of imported namespaces across different modules.

Screenshots or Video

N/A

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests.
  • Commits messages follow AP format.
  • Extend the documentation, if necessary.
  • Merging to main from fork:Yash_fixing-bugs.

@dselman
Copy link
Contributor

dselman commented Sep 24, 2024

You've reformatted the files making it very hard to review your changes. Can you please resubmit without reformatting?

@yashsaraswat2004
Copy link
Author

I'm really sorry to change the formatting of code. I will sure resubmit it without reformatting.

dselman
dselman requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impossible to review due to amount of whitespace changes.

@yashsaraswat2004 yashsaraswat2004 closed this by deleting the head repository Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dselman dselman dselman requested changes

@sandyyash15 sandyyash15 sandyyash15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redefining an imported type is allowed
3 participants
@yashsaraswat2004 @dselman @sandyyash15