Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hereje/i763/refactor/migrate to esm/concerto types #779

Open
wants to merge 18 commits into
base: v4.0.0
Choose a base branch
from

Conversation

hereje
Copy link

@hereje hereje commented Jan 9, 2024

Closes #763 => packages/concerto-types

Changes

  • convert project to ESM
  • update script and test files accordingly

Flags

  • Jest configuration on package.json

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:hereje/i763/refactor/migrate-to-esm/concerto-types

mttrbrts and others added 3 commits November 24, 2023 13:26
* feat(types): build uniontypes too

Signed-off-by: Matt Roberts <[email protected]>

* fix(build): include unions in index

Signed-off-by: Matt Roberts <[email protected]>

* chore(deps): upgrade codegen to latest release

Signed-off-by: Matt Roberts <[email protected]>

---------

Signed-off-by: Matt Roberts <[email protected]>
…#767)

* fix(parser): throw error when concept is extending itself in CTO

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* fix(parser): throw error when concept is extending itself in JSON metamodel form

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* fix(parser): throw error when concept is extending itself in the AST

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* refactor(validation): alphabetical rearrangement

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* test(self-extending): remove redundant tests (codepath covered in concerto-cto)

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* test(fix): remove unneeded import

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

---------

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>
Co-authored-by: Stefan Blaginov <[email protected]>
@mttrbrts mttrbrts changed the base branch from main to v4.0.0 February 6, 2024 14:59
@mttrbrts
Copy link
Member

Hi @hereje, as this is a breaking change, we need to target the v4 branch. Are you willing to rebase this on top of that branch, please?

ekarademir and others added 12 commits February 29, 2024 09:35
…ccordproject#773)

* fix(error): adding type to error in string validator in introspect

Signed-off-by: Santanu Roy <[email protected]>
Co-authored-by: Santanu Roy <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: DianaLease <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
- update package.json
 * update engine node to 16
 * update jest preset for esm
 * update other jest settings

- update tsconfig.json for module resolution

Signed-off-by: Angel Mendez Cano <[email protected]>
* v4.0.0-alpha.0

* feat!(*): strict by default

Signed-off-by: Matt Roberts <[email protected]>

* test(*): version everything

Signed-off-by: Matt Roberts <[email protected]>

* test(*): fix more tests

Signed-off-by: Matt Roberts <[email protected]>

* refactor(core): modelfile logic for isImportedType

Signed-off-by: Matt Roberts <[email protected]>

---------

Signed-off-by: Matt Roberts <[email protected]>
* chore!(core): migrate to TS project

Signed-off-by: Matt Roberts <[email protected]>

* chore!(*): migrate vocab, util and cto packages to TS projects

Signed-off-by: Matt Roberts <[email protected]>

* fix(deps): npm-run-all

Signed-off-by: Matt Roberts <[email protected]>

* fix(*): code coverage

Signed-off-by: Matt Roberts <[email protected]>

* chore(*): migrate to npm workspaces

Signed-off-by: Matt Roberts <[email protected]>

---------

Signed-off-by: Matt Roberts <[email protected]>

fix(*): fix buggy merge conflicts

Signed-off-by: Matt Roberts <[email protected]>

fix(build): topological sort of packages

Signed-off-by: Matt Roberts <[email protected]>

fix(build): topological sort of package names 2

Signed-off-by: Matt Roberts <[email protected]>
* fix(core): detect ambiguous imports / declarations

Signed-off-by: Matt Roberts <[email protected]>

* fix(lint): assetdeclaration

Signed-off-by: Matt Roberts <[email protected]>

---------

Signed-off-by: Matt Roberts <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
@hereje hereje force-pushed the hereje/i763/refactor/migrate-to-esm/concerto-types branch from 399ad72 to 53bd592 Compare February 29, 2024 15:48
…tor/migrate-to-esm/concerto-types

Signed-off-by: Angel Mendez Cano <[email protected]>
@mttrbrts
Copy link
Member

@hereje can you rebase your changes on top of the latest v4.0.0 branch, please? I see that this PR has lots of unrelated changes now too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to ESM from CommonJS Modules
4 participants