-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hereje/i763/refactor/migrate to esm/concerto types #779
Open
hereje
wants to merge
18
commits into
accordproject:v4.0.0
Choose a base branch
from
hereje:hereje/i763/refactor/migrate-to-esm/concerto-types
base: v4.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
hereje/i763/refactor/migrate to esm/concerto types #779
hereje
wants to merge
18
commits into
accordproject:v4.0.0
from
hereje:hereje/i763/refactor/migrate-to-esm/concerto-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(types): build uniontypes too Signed-off-by: Matt Roberts <[email protected]> * fix(build): include unions in index Signed-off-by: Matt Roberts <[email protected]> * chore(deps): upgrade codegen to latest release Signed-off-by: Matt Roberts <[email protected]> --------- Signed-off-by: Matt Roberts <[email protected]>
…#767) * fix(parser): throw error when concept is extending itself in CTO Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> * fix(parser): throw error when concept is extending itself in JSON metamodel form Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> * fix(parser): throw error when concept is extending itself in the AST Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> * refactor(validation): alphabetical rearrangement Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> * test(self-extending): remove redundant tests (codepath covered in concerto-cto) Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> * test(fix): remove unneeded import Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> --------- Signed-off-by: Stefan Blaginov <[email protected]> Signed-off-by: Stefan Blaginov <[email protected]> Co-authored-by: Stefan Blaginov <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: stefanblaginov <[email protected]>
Hi @hereje, as this is a breaking change, we need to target the v4 branch. Are you willing to rebase this on top of that branch, please? |
…oject#771) Signed-off-by: Ertugrul Karademir <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
…ccordproject#773) * fix(error): adding type to error in string validator in introspect Signed-off-by: Santanu Roy <[email protected]> Co-authored-by: Santanu Roy <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: DianaLease <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
- update package.json * update engine node to 16 * update jest preset for esm * update other jest settings - update tsconfig.json for module resolution Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
* v4.0.0-alpha.0 * feat!(*): strict by default Signed-off-by: Matt Roberts <[email protected]> * test(*): version everything Signed-off-by: Matt Roberts <[email protected]> * test(*): fix more tests Signed-off-by: Matt Roberts <[email protected]> * refactor(core): modelfile logic for isImportedType Signed-off-by: Matt Roberts <[email protected]> --------- Signed-off-by: Matt Roberts <[email protected]>
Signed-off-by: Matt Roberts <[email protected]>
* chore!(core): migrate to TS project Signed-off-by: Matt Roberts <[email protected]> * chore!(*): migrate vocab, util and cto packages to TS projects Signed-off-by: Matt Roberts <[email protected]> * fix(deps): npm-run-all Signed-off-by: Matt Roberts <[email protected]> * fix(*): code coverage Signed-off-by: Matt Roberts <[email protected]> * chore(*): migrate to npm workspaces Signed-off-by: Matt Roberts <[email protected]> --------- Signed-off-by: Matt Roberts <[email protected]> fix(*): fix buggy merge conflicts Signed-off-by: Matt Roberts <[email protected]> fix(build): topological sort of packages Signed-off-by: Matt Roberts <[email protected]> fix(build): topological sort of package names 2 Signed-off-by: Matt Roberts <[email protected]>
* fix(core): detect ambiguous imports / declarations Signed-off-by: Matt Roberts <[email protected]> * fix(lint): assetdeclaration Signed-off-by: Matt Roberts <[email protected]> --------- Signed-off-by: Matt Roberts <[email protected]> Signed-off-by: Angel Mendez Cano <[email protected]>
hereje
force-pushed
the
hereje/i763/refactor/migrate-to-esm/concerto-types
branch
from
February 29, 2024 15:48
399ad72
to
53bd592
Compare
…tor/migrate-to-esm/concerto-types Signed-off-by: Angel Mendez Cano <[email protected]>
Signed-off-by: Angel Mendez Cano <[email protected]>
@hereje can you rebase your changes on top of the latest v4.0.0 branch, please? I see that this PR has lots of unrelated changes now too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763 => packages/concerto-types
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:hereje/i763/refactor/migrate-to-esm/concerto-types