chore(refund-vault): remove unused DataKey and Error variants (#170) - #260
Merged
Merged
Conversation
…Max, Admins, Threshold) and error variants (MetadataTooLong, AmountExceedsMax) Removes four storage key variants that no code reads or writes, and two #[contracterror] discriminants (codes 10, 11) that are never returned. Discriminant gaps left intentionally — codes are a published interface. ReceiptAnchor checked: all DataKey and Error variants are reachable. Closes accensa#170
|
MergeKeeper review Scope: in scope for linked issue The pull request correctly removes the unused DataKey and Error variants from RefundVault and contracts/common while preserving discriminant gaps and checking ReceiptAnchor as requested. Reviewed commit: |
|
MergeKeeper merge status Status: blocked Reason: One or more required CI checks failed. Failing checks:
Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Unused Storage Keys and Error Variants
Removes dead code from the contract's published ABI.
RefundVault DataKey (removed)
Metadata— never written or readRefundMax— never written or readAdmins— never written or read (implied M-of-N scheme that was never built)Threshold— never written or readCommon Error (removed, discriminant gaps preserved)
MetadataTooLong = 10— never returnedAmountExceedsMax = 11— never returnedDiscriminant gaps at 10 and 11 are intentional — codes are a published interface
and live contracts exist in
deployments/.ReceiptAnchor checked: all DataKey and Error variants are reachable.
Closes #170