feat(refund-vault): commit-reveal to prevent front-running (issue #128) - #255
Open
tecmalik wants to merge 2 commits into
Open
feat(refund-vault): commit-reveal to prevent front-running (issue #128)#255tecmalik wants to merge 2 commits into
tecmalik wants to merge 2 commits into
Conversation
…ensa#128) Add a commit-reveal scheme to RefundVault so a mempool observer cannot front-run refunds/withdrawals. A merchant first commits an opaque sha256(plaintext || salt) hash (merchant-auth only), then reveals the plaintext + salt after COMMIT_REVEAL_DELAY (10) ledgers; the contract re-hashes, verifies against the stored commitment, consumes it and runs the identical refund/withdraw (shared do_refund/do_withdraw). New public API: commit, reveal_refund, reveal_withdraw, get_commitment, get_commit_reveal_delay. New Error codes 302-305 (CommitmentNotFound, CommitmentMismatch, CommitmentNotDue, CommitmentAlreadyUsed). Security audit tests in commit_reveal_tests.rs pin the min-delay boundary, mismatch rejection, duplicate-commit rejection, merchant-only commit, and commitment opacity. Docs (README, SECURITY_MODEL, CHANGELOG) updated; wasm budget bumped to 49152. Also fixes pre-existing lib-test blockers (Events import, self-transfer event-count assertions, fuzz nonminimal_bool).
|
@tecmalik Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #128
Summary
Contract Change Safety Checklist
Please verify that your changes adhere to contract stability requirements:
docs/EVENTS.md)CHANGELOG.md?DEPLOYMENTS.mdbeen documented?cargo test) and/or exercised on Soroban testnet?Related Issues
Closes #