Skip to content

Fix: No crate declares an MSRV, so a stable toolchain bump can break the build with no warning (Auto-Generated) - #223

Merged
wagmiiii merged 7 commits into
accensa:mainfrom
Ennyblack:driptide/issue-173-1787774725492
Aug 30, 2026
Merged

Fix: No crate declares an MSRV, so a stable toolchain bump can break the build with no warning (Auto-Generated)#223
wagmiiii merged 7 commits into
accensa:mainfrom
Ennyblack:driptide/issue-173-1787774725492

Conversation

@Ennyblack

Copy link
Copy Markdown
Contributor

Closes #173

This pull request was generated automatically and scoped strictly to issue #173.

Changes

Determined the minimum supported Rust version (MSRV) for soroban-sdk 27.0.4 to be 1.82.0 based on SDK dependencies and build compatibility. Added rust-version = "1.82.0" to [workspace.package] in the root Cargo.toml, and inherited it in contracts/receipt-anchor/Cargo.toml and contracts/refund-vault/Cargo.toml. Added an MSRV CI job in .github/workflows/ci.yml that uses dtolnay/rust-toolchain@1.82.0 to run cargo build and cargo test.

Verification

⚠️ Not verified locally (no build system detected, or the required toolchain isn't installed on the worker). GitHub CI is the source of truth — please check the CI status on this PR before merging.

Linked with Closes #173 so the Drips Wave bot resolves the issue on merge.

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@Ennyblack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 26, 2026

Copy link
Copy Markdown

Needs changes

The PR modifies crate-type configurations and adds unnecessary changes outside the scope of declaring workspace rust-version.

Reviewed commit: 1f35fcb916be72cb2693c4d2162c50e932c3adab.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The PR introduces unrelated formatting and configuration removals in the crate manifests, such as dropping workspace lints and dev-dependencies like proptest.

  • contracts/receipt-anchor/Cargo.toml:5: Removed [lints] workspace inheritance and proptest dependency which are unrelated to adding rust-version.
  • contracts/refund-vault/Cargo.toml:5: Removed [lints] workspace inheritance, proptest dependency, and receipt-anchor dev-dependency which are unrelated to adding rust-version.

Reviewed commit: a25a90d35774b86547362d6687e3110dcf864464.

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown

Needs review

Linked to #173, but the diff does not match the issue scope.

The pull request only removes blank lines in crate Cargo.toml files and completely omits all required changes: declaring rust-version in Cargo.toml, inheriting it in workspace crates, and adding the MSRV CI workflow job.

Reviewed commit: 6fb9b1ea18f85689885469595147f31e4aa947bc.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The PR modifies crate-type configurations and adds unnecessary changes outside the scope of declaring workspace rust-version.

  • contracts/receipt-anchor/Cargo.toml:19: Unnecessarily reformatted crate-type and rearranged Cargo.toml sections without being requested by issue #173.
  • contracts/refund-vault/Cargo.toml:19: Unnecessarily reformatted crate-type and rearranged Cargo.toml sections without being requested by issue #173.

Reviewed commit: 1f35fcb916be72cb2693c4d2162c50e932c3adab.

@Ennyblack

Copy link
Copy Markdown
Contributor Author

Fix Applied

Restored workspace lints and dev-dependencies (including proptest and receipt-anchor) in receipt-anchor and refund-vault Cargo.toml files while keeping rust-version.configured properly.

This fix was automatically generated in response to your comment.

@wagmiiii
wagmiiii merged commit 2a0bf42 into accensa:main Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No crate declares an MSRV, so a stable toolchain bump can break the build with no warning

2 participants