chore: adopt a formatter — fix mangled whitespace, add .editorconfig and SDK lint - #278
Conversation
|
@samlogy1 is attempting to deploy a commit to the ACCENSA Team on Vercel. A member of the Team first needs to authorize it. |
|
MergeKeeper review Scope: in scope for linked issue The PR successfully resolves the formatting and tooling requirements specified in issue #98. Reviewed commit: |
|
MergeKeeper merge status Status: blocked Reason: This branch has merge conflicts with the current base branch. Next steps:
|
|
@timo126 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Needs changes The PR modifies apps/web/src/lib/freighter.ts to rewrite the entire file instead of merely formatting/repairing string literals, which falls outside the scope of issue #98.
Reviewed commit: |
There was a problem hiding this comment.
Needs changes
The PR modifies apps/web/src/lib/freighter.ts to rewrite the entire file instead of merely formatting/repairing string literals, which falls outside the scope of issue #98.
apps/web/src/lib/freighter.ts:1: Substantial rewrite of freighter.ts was included in this PR, which is outside the scope of adopting a formatter, fixing mangled strings, adding .editorconfig, and extending SDK linting.
Reviewed commit: 24b845828556bc8091a76c3cab063487fcd8d37a.
6982901 to
6716760
Compare
baa0da5 to
57567be
Compare
Summary
Closes #98
This PR adopts Prettier as the project-wide formatter, repairs all mangled string literals left behind by bad merges, extends ESLint coverage to
packages/sdk, and adds.editorconfig+.gitattributesso editors and git agree on whitespace before code is ever committed.What changed
Commit 1:
fix: resolve merge conflict, repair mangled strings, add .editorconfig and SDK lintMerge conflict resolution
apps/web/src/app/api/sync/route.tshad unresolved conflict markers. Both imports (isAuthorizedCronRequestandcreateHmac) are used — kept both.Mangled string literals repaired (16 instances)
A grep for
[a-zA-Z]"[a-zA-Z]acrossapps/web/srcconfirmed 16 locations where quotes were jammed against adjacent words. These are inside comments, JSDoc, and template-literal SQL — syntactically valid, so no linter or formatter will ever flag them. All 16 were fixed by hand.Examples:
db.ts:80:COLUMN"timestamp"TO→COLUMN "timestamp" TOsync/route.ts:362:dashboard's"Sync now"button→dashboard's "Sync now" buttonstellar-events.ts:13:e.g."native"or"USDC:GA..."→e.g. "native" or "USDC:GA..."Post-fix grep confirms zero remaining mangled strings.
.editorconfigadded — matches the Prettier config (2-space indent, LF, UTF-8)..gitattributesadded — enforceseol=lfrepo-wide so Windows contributors never commit CRLF.ESLint extended to
packages/sdk— flat config withtypescript-eslintrecommended rules +lintscript added topackage.json.apps/demo-merchantESLint gap (justified) — plain JS demo app with no build step; adding ESLint there would require a separate config for a handful of rarely-changing files.CONTRIBUTING.mdupdated — now mentions.editorconfig, ESLint coverage, and the full pre-commit workflow..gitignoreupdated — prevents local tooling artifacts (node_dist/,*.zip, etc.) from being committed.Commit 2:
style: apply prettier formatting across the entire codebaseA single
prettier --write .run that touches only formatting — no logic, no renames, no API changes. Listed in.git-blame-ignore-revs.Commit 3:
chore: add format commit to .git-blame-ignore-revsRecords the format commit in
.git-blame-ignore-revsalongside the two earlier format commits.Acceptance criteria checklist
packages/sdk/index.ts)054f864).git-blame-ignore-revsformat:checkruns in CI over every workspace (already inci.yml)packages/sdk;apps/demo-merchantgap justified.editorconfigcommitted;CONTRIBUTING.mdmentions the formatter