feat: structured logging and error tracking (#99) - #273
Conversation
|
@timo126 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@samlogy1 is attempting to deploy a commit to the ACCENSA Team on Vercel. A member of the Team first needs to authorize it. |
|
MergeKeeper review Scope: in scope for linked issue Structured logging, sync run persistence, Sentry error tracking, redaction tests, and deployment documentation were successfully implemented. Reviewed commit: |
|
MergeKeeper merge status Status: blocked Reason: One or more required CI checks failed. Failing checks:
Next steps:
|
|
MergeKeeper review unavailable AI provider review response did not contain valid JSON No approval or merge action was taken. |
a73ac8e to
078fd7b
Compare
8e9e7f9 to
9018755
Compare
|
Needs changes The PR implements some logging and Sentry configs, but misses several acceptance criteria from #99 such as persisting sync runs, API route error/request logging, PII docs, LOG_LEVEL docs, and DEPLOYMENT.md.
Reviewed commit: |
There was a problem hiding this comment.
Needs changes
The PR implements structured logging, redaction tests, and Sentry configuration, but misses persisting sync history to a sync_runs table, logging sync runs, wiring Sentry into API routes, adding API route request tracking, PII documentation, LOG_LEVEL documentation, and DEPLOYMENT.md.
apps/web/src/lib/log.ts: Missing persistence of sync run results to async_runstable as specified in issue #99.apps/web/src/lib/log.ts: Missing wiring of Sentry error tracking and structured logging into API routes and request correlation.- Review finding: Missing
DEPLOYMENT.mdexplaining where logs go and how to query them, and documentation forLOG_LEVELand PII scrubbing.
Reviewed commit: 88fc4311242fc9701128e440cf4fc46e9ef568b2.
There was a problem hiding this comment.
Needs changes
The PR implements some logging and Sentry configs, but misses several acceptance criteria from #99 such as persisting sync runs, API route error/request logging, PII docs, LOG_LEVEL docs, and DEPLOYMENT.md.
apps/web/src/lib/log.ts: Sync run results are not persisted to async_runstable as required by the issue.apps/web/sentry.server.config.ts: Error tracking and structured logging are not wired into API routes or error boundaries.- Review finding: Missing
DEPLOYMENT.mdexplaining log querying and where logs go. - Review finding: Missing documentation for
LOG_LEVELconfiguration and PII scrubbing.
Reviewed commit: dd737396ce80928b1d0dd77ed80d42c2cf27b64f.
closes #99