Skip to content

feat: structured logging and error tracking (#99) - #273

Open
timo126 wants to merge 3 commits into
accensa:mainfrom
timo126:feat-99-structured-logging
Open

feat: structured logging and error tracking (#99)#273
timo126 wants to merge 3 commits into
accensa:mainfrom
timo126:feat-99-structured-logging

Conversation

@timo126

@timo126 timo126 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

closes #99

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@timo126 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@samlogy1 is attempting to deploy a commit to the ACCENSA Team on Vercel.

A member of the Team first needs to authorize it.

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown

MergeKeeper review

Scope: in scope for linked issue #99.
Verdict: clean

Structured logging, sync run persistence, Sentry error tracking, redaction tests, and deployment documentation were successfully implemented.

Reviewed commit: f703c38d6bb6c78e7467c2d33913ee1807d563bd.
CI and merge eligibility are checked separately.

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown

MergeKeeper merge status

Status: blocked
PR state: open
Mergeability: mergeable
Checked commit: f703c38d6bb6c78e7467c2d33913ee1807d563bd.

Reason: One or more required CI checks failed.

Failing checks:

Next steps:

  1. Open the failing check details above and fix the reported error.
  2. Run the same checks locally where possible.
  3. Commit and push the fix.
  4. MergeKeeper will automatically re-review the updated PR.

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown

MergeKeeper review unavailable

AI provider review response did not contain valid JSON

No approval or merge action was taken.

@timo126
timo126 force-pushed the feat-99-structured-logging branch 2 times, most recently from a73ac8e to 078fd7b Compare August 29, 2026 09:18
@timo126
timo126 force-pushed the feat-99-structured-logging branch from 8e9e7f9 to 9018755 Compare August 29, 2026 12:44
@mergekeeper

mergekeeper Bot commented Aug 29, 2026

Copy link
Copy Markdown

Needs changes

The PR implements some logging and Sentry configs, but misses several acceptance criteria from #99 such as persisting sync runs, API route error/request logging, PII docs, LOG_LEVEL docs, and DEPLOYMENT.md.

  • apps/web/src/lib/log.ts: Sync run results are not persisted to a sync_runs table as required by the issue.
  • apps/web/sentry.server.config.ts: Error tracking and structured logging are not wired into API routes or error boundaries.
  • Review finding: Missing DEPLOYMENT.md explaining log querying and where logs go.
  • Review finding: Missing documentation for LOG_LEVEL configuration and PII scrubbing.

Reviewed commit: dd737396ce80928b1d0dd77ed80d42c2cf27b64f.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The PR implements structured logging, redaction tests, and Sentry configuration, but misses persisting sync history to a sync_runs table, logging sync runs, wiring Sentry into API routes, adding API route request tracking, PII documentation, LOG_LEVEL documentation, and DEPLOYMENT.md.

  • apps/web/src/lib/log.ts: Missing persistence of sync run results to a sync_runs table as specified in issue #99.
  • apps/web/src/lib/log.ts: Missing wiring of Sentry error tracking and structured logging into API routes and request correlation.
  • Review finding: Missing DEPLOYMENT.md explaining where logs go and how to query them, and documentation for LOG_LEVEL and PII scrubbing.

Reviewed commit: 88fc4311242fc9701128e440cf4fc46e9ef568b2.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The PR implements some logging and Sentry configs, but misses several acceptance criteria from #99 such as persisting sync runs, API route error/request logging, PII docs, LOG_LEVEL docs, and DEPLOYMENT.md.

  • apps/web/src/lib/log.ts: Sync run results are not persisted to a sync_runs table as required by the issue.
  • apps/web/sentry.server.config.ts: Error tracking and structured logging are not wired into API routes or error boundaries.
  • Review finding: Missing DEPLOYMENT.md explaining log querying and where logs go.
  • Review finding: Missing documentation for LOG_LEVEL configuration and PII scrubbing.

Reviewed commit: dd737396ce80928b1d0dd77ed80d42c2cf27b64f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ops: structured logging and error tracking for the dashboard and indexer

2 participants