Open
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Test SUCCESS. |
ilansmith
reviewed
Jan 15, 2017
| } | ||
| Msg msg = listMsg.poll(); | ||
| msg.setMsgReturnable(); | ||
| if (msg != null) { |
ilansmith
reviewed
Jan 16, 2017
ilansmith
left a comment
ilansmith
left a comment
There was a problem hiding this comment.
Sorry, one more thing I forgot - commits should be signed-off-by. I know this hasn't always been preserved, but better late than never. Please re-commit with -s.
The indentation is OK, except that the 'if' block (msg.setMsg...) should be indented by a single tab relative to the 'if' statement - without the spaces after the tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.