Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new popover-menu component #139

Conversation

Coderwelsch
Copy link
Contributor

@Coderwelsch Coderwelsch commented Aug 5, 2024

I needed to add a new popover menu component (I’ve used the navigation popover implementation from our hailstorm as reference) to get rid of evergreen’s popover elements in portal :-)

CleanShot 2024-08-05 at 14 15 25

@Coderwelsch Coderwelsch requested a review from mnlfischer August 5, 2024 11:52
@Coderwelsch Coderwelsch self-assigned this Aug 5, 2024
Copy link

linear bot commented Aug 5, 2024

@Coderwelsch Coderwelsch requested a review from rodelta August 5, 2024 11:52
Copy link
Contributor

@rodelta rodelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
I don't know if it's intended, but the border is going outside the container for a few pixels
CleanShot 2024-08-05 at 14 23 43

Also, please make sure to align with roberto, so he's aware of this component and can update the figma file so this is represented.

@Coderwelsch Coderwelsch merged commit 204e604 into main Aug 5, 2024
7 checks passed
@Coderwelsch Coderwelsch deleted the pla-1313-hailstorm-add-popover-component-for-evergreen-popover branch August 5, 2024 12:25
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants