Fix linkcheck #147
Fix linkcheck #147
Conversation
| @@ -240,6 +240,7 @@ package: | |||
| Maintainer tasks | |||
| ================ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This isn't really needed?
There was a problem hiding this comment.
Needed...
validate-pyproject git:(fix-linkcheck) ✗ reading sources... [100%] readme .. schemas
CONTRIBUTING.rst:243: CRITICAL: Title level inconsistent:
Releases
--------
There was a problem hiding this comment.
So that is how to fix this warning!
The rst spec is surprisingly pedantic O.o
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
|
|
|||
| "$id": "https://packaging.python.org/en/latest/specifications/declaring-build-dependencies/", | |||
| "$id": "https://packaging.python.org/en/latest/specifications/dependency-specifiers/", | |||
There was a problem hiding this comment.
I see that this new ref fix linkcheck however it is not the best reference.
The new PyPA docs now unify both the [build-system] table and the [project] table into a single URL: https://packaging.python.org/en/latest/specifications/pyproject-toml/.
We could try to use fragments like in https://packaging.python.org/en/latest/specifications/pyproject-toml/#pyproject-build-system-table, but I have the impression that this will confuse the validation (I might be wrong though).
For the time being we can live as it is, because it is not hurting anyone...
The folks maintaining the docs are currently having a look on what happened to the redirect: pypa/packaging.python.org#1486.
@cclauss is it OK if once they finished debugging the redirects we return the old URL? It is going to be a 30X status, I am not sure if that will fail the linkcheck... Alternatively we can test the fragments and see if they actually break something...
There was a problem hiding this comment.
Please go ahead and revert the specification changes if you think that is the right thing to do.
The old URLs do not exist (404 error) but those were only warnings, not errors in linkcheck.
The linkcheck error was that blank line!
No description provided.