-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An app to detect licenses from the provided input license text #450
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Akhil Raj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lf32 That's a good start, see my comments for minor improvements.
In the future you need to provide more context than simply requesting a review.
There's a tons of commented code, which part do you need to be reviewed?
Include what you have accomplished and what is left to do, also include the issues you are facing.
scantext/templates/scantext/includes/license_summary_level.html
Outdated
Show resolved
Hide resolved
scantext/templates/scantext/includes/license_summary_level.html
Outdated
Show resolved
Hide resolved
scantext/templates/scantext/includes/license_summary_level.html
Outdated
Show resolved
Hide resolved
thanks, i pinged you to let you know about the PR
|
Still checking this! will let you know ASAP |
You are putting side by side a form submit button "Scan License" and a navigation link "New Project". I think the "New Project" as no need to be present in that view. |
Conflicts: scanpipe/templates/scanpipe/base.html
@tdruez please suggest changes and also any resource for recommending license? |
This looks awesome but where is the code? No code, no review possible.
I don't know what you mean by that. |
* Dropdown cards work well in the details page * Re-arranged html code * Changed Scan path from /scan/ to /scantext/ Signed-off-by: Akhil Raj <[email protected]>
I have just pushed changes over here |
Signed-off-by: Akhil Raj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lf32 that's a great start, see my comments for minor improvements.
I think the UI is fine for now, you should focus on the views code to make it working on real input text.
564b5fe
to
49fe7a5
Compare
@lf32 please read the following for future commit messages (no need to update the existing ones): https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html For example: "changed card title from name to short_name" should be "Change card title from name to short_name #450" You can look at the commit history of the repo and try to follow the conventions in place. |
* Set Input Textarea to 15 * Added file-upload into form * Changed <pre> to <textarea> in the details page * Modified Navigation Bar and Renamed Scan Again Button Signed-off-by: Akhil Raj <[email protected]>
* license_scanview function uses tempfile to run license detection on the provided input license text Signed-off-by: Akhil Raj <[email protected]>
* license_scanview function uses tempfile to run license detection on the provided input license text Signed-off-by: Akhil Raj <[email protected]>
7e11c91
to
d3dbb17
Compare
* license_scanview uses tempfile to run license detection on the provided input license text Signed-off-by: Akhil Raj <[email protected]>
d3dbb17
to
64ffe39
Compare
* Set Input Textarea to 15 * Added file-upload into form * Changed <pre> to <textarea> in the details page * Modified Navigation Bar and Renamed Scan Again Button Signed-off-by: Akhil Raj <[email protected]>
64ffe39
to
cb9de2d
Compare
* license_scanview function uses tempfile to run license detection on the provided input license text Signed-off-by: Akhil Raj <[email protected]>
Signed-off-by: Akhil Raj <[email protected]>
Signed-off-by: Akhil Raj <[email protected]>
Hi @lf32 what's the latest status on this PR? |
@tdruez I am writing the tests. |
|
@lf32 Thanks for the update! |
Signed-off-by: Akhil Raj <[email protected]>
Signed-off-by: Akhil Raj <[email protected]>
per @pombredanne we need to determine if this properly belongs in ScanCode.io or in a separate application. The design-to-date is a separate app. |
This feature helps in working with files of type text or other (example: binary) Signed-off-by: Akhil Raj <[email protected]>
Signed-off-by: Akhil Raj <[email protected]>
@AyanSinhaMahapatra, I have added a utilities dropdown and moved |
Hi @lf32 what's the latest status on this PR? Is it feature complete? |
@tdruez I have discussed with philippe about it and still needs changes to be made. |
@lf32 Can you provide a list of those changes? |
|
Signed-off-by: Akhil Raj <[email protected]>
The aim of this PR is to create a working app inside this Django project to detect licenses from the provided input text and summarize the results for the end user.