Skip to content

add length to progress bar #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add length to progress bar #4100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ This is a patch release with bugfixes and improvements::
https://github.com/aboutcode-org/scancode-toolkit/pull/4476


- Progress bar now shows length. You can estimate the duration now.
See https://github.com/aboutcode-org/scancode-toolkit/issues/3342

v32.4.0 - 2025-06-26
--------------------

Expand Down
4 changes: 4 additions & 0 deletions src/scancode/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,8 @@ def scan_codebase(

# NOTE: we never scan directories
resources = ((r.location, r.path) for r in codebase.walk() if r.is_file)
if progress_manager:
resources = list(resources)

use_threading = processes >= 0
runner = partial(
Expand Down Expand Up @@ -1287,6 +1289,8 @@ def scan_codebase(

if progress_manager:
scans = progress_manager(scans)
# times two because of #3344
scans.length = len(resources)*2
# hack to avoid using a context manager
if hasattr(scans, '__enter__'):
scans.__enter__()
Expand Down