feat(python): add package typing stubs#6
Draft
abnobdoss wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds package-level typing support for the Python modules currently exposed by
pyiceberg_coreonmain:pyiceberg_core.transformpyiceberg_core.manifestpyiceberg_core.datafusionAlso adds
py.typedso type checkers treat the package as maintainer-typed.Why
The runtime binding PRs intentionally avoid adding one-off
.pyifiles while existing Python modules are untyped. This PR centralizes typing as a package-wide concern instead.Follow-up runtime PRs that add new Python modules can either wait for this to land and then add their own stubs in a typing follow-up, or extend this PR after their runtime APIs land.
Testing