python: support arrow reader row limits#10
Draft
abnobdoss wants to merge 1 commit into
Draft
Conversation
abnobdoss
force-pushed
the
aba-162-arrow-reader-exact-schema
branch
2 times, most recently
from
8432ca9 to
0844a9e
Compare
abnobdoss
force-pushed
the
aba-163-arrow-reader-limit
branch
from
2d504a4 to
526ded8
Compare
abnobdoss
force-pushed
the
aba-162-arrow-reader-exact-schema
branch
from
0844a9e to
78787c0
Compare
abnobdoss
force-pushed
the
aba-163-arrow-reader-limit
branch
from
526ded8 to
5d38ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position: Rust PR after #9 (ABA-163).
Adds
max_rowssupport to pyiceberg_core ArrowReader so native RecordBatchReader output can preserve PyIceberg DataScan.limit semantics.Validation reported by implementer:
Current status: draft, under Codex red-team review. Known red-team focus: whether max_rows over-reads one extra batch, max_rows=0, batch slicing behavior, and stream termination semantics.