Clarify how to handle msgSerial when RTN15 check fails #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm on the fence about RTN15g4 — we do already say "clear the local connection state" in RTN15g but I'm not sure if this is a very well-defined thing. Maybe we need to instead have a section which defines what this entails?
yes, I think would be clearer to have a spec point that says "Clearing the connection state means: clearing any stored connection key, clearing any stored connection id, and setting the internal counter used to assign the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on the fence about RTN15g4 — we do already say "clear the local connection state" in RTN15g but I'm not sure if this is a very well-defined thing. Maybe we need to instead have a section which defines what this entails?
TODO I need to actually compare this to #351, seems related