Clarify the default values for newly created LiveMap and LiveCounter in RTLM4 and RTLC4 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
approved these changes
Sep 4, 2025
VeskeR
force-pushed
the
PUB-1829/object-write-API
branch
from
ffed7d7 to
79ad8d9
Compare
sacOO7
reviewed
Sep 5, 2025
|
|
||
| enum PluginType // PT* | ||
| "vcdiff" // PT2a | ||
| "Objects" // PT2b |
There was a problem hiding this comment.
Suggested change
| "Objects" // PT2b | |
| "LiveObjects" // PT2b |
as per internal discussion -> https://ably-real-time.slack.com/archives/C03JDBVM5MY/p1756815963123829
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry, this change is not part of this PR and was added a long time ago.
It appeared here only because of numerous changes in the PRs that this one was based on, causing all commits from the previous PRs to show up.
I’ve rebased this PR onto the latest main, and now it correctly reflects only the intended changes to LiveCounter and LiveMap creation.
Please re-review this PR now that it correctly shows its changes.
For the plugin name change though, I've created #377 to update that
VeskeR
force-pushed
the
PUB-1829/object-write-API
branch
from
79ad8d9 to
3517453
Compare
…in RTLM4 and RTLC4 Also remove the term "zero-value" object as it is an unnecessary detail that simply describes a newly created object according to RTLM4 and RTLC4
VeskeR
force-pushed
the
clarify-zero-value-objects
branch
from
9259335 to
3f07faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the term "zero-value" object as it is an unnecessary detail that simply describes a newly created object according to RTLM4 and RTLC4