[PUB-1827] Add Objects spec for subscriptions #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeskeR
force-pushed
the
PUB-1827/objects-subscriptions
branch
from
01b4bec to
2963300
Compare
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 11, 2025
The correct behaviour wasn't clear from the spec when I wrote cb427d8, but new spec PR [1] makes it seem that this is the right thing to do (still needs clarifying though). [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 11, 2025
TODO test TODO call listeners on SDK's callback queue Based on [1] at 2963300. Implementation written by me [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
The correct behaviour wasn't clear from the spec when I wrote cb427d8, but new spec PR [1] makes it seem that this is the right thing to do (still needs clarifying though). [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. pretty much all done by me, only a bit of dependency injection test updates were done by cursor for now don't test replaceData return value since not specified TODO need to sort out the weird @SPEC(…) that were added in OBJECT_SYNC Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. pretty much all done by me, only a bit of dependency injection test updates were done by cursor for now don't test replaceData return value since not specified Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
The correct behaviour wasn't clear from the spec when I wrote cb427d8, but new spec PR [1] makes it seem that this is the right thing to do (still needs clarifying though). [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
The correct behaviour wasn't clear from the spec when I wrote cb427d8, but new spec PR [1] makes it seem that this is the right thing to do (still needs clarifying though). [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
The correct behaviour wasn't clear from the spec when I wrote cb427d8, but new spec PR [1] makes it seem that this is the right thing to do (still needs clarifying though). [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 16, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
sacOO7
reviewed
Jul 18, 2025
| unsubscribe((LiveObjectUpdate) ->) // RTLO4c | ||
| unsubscribeAll() // RTLO4d | ||
|
|
||
| interface LiveObjectSubscription: // RTLO4b5 |
There was a problem hiding this comment.
Suggested change
| interface LiveObjectSubscription: // RTLO4b5 | |
| interface ObjectsSubscription: // RTLO4b5 |
Athough, we have a LiveObject class, it's internal and we chose not to use this naming convention right?
I think we can have a common interface that implements unsubscribe for all type of subscribe or on methods
There was a problem hiding this comment.
Athough, we have a LiveObject class, it's internal and we chose not to use this naming convention right?
The LiveObject interface is exposed in ably-js implementation and the naming convention is correct in this case. This is a "live object" - an object whose data is synced in realtime - and its name only coincidentally resembles the name of the LiveObjects feature.
The LiveObjectSubscription in this case represents a subscription for a LiveObject instance, so I think the name should remain as it is.
I think we can have a common interface that implements unsubscribe for all type of subscribe or on methods
The current API uses the subscribe/unsubscribe and on/off naming pairs, so for .on methods the returned object should expose .off() method I think.
sacOO7
reviewed
Jul 21, 2025
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 23, 2025
The correct behaviour wasn't clear from the spec when I wrote cb427d8, but new spec PR [1] makes it seem that this is the right thing to do (still needs clarifying though). [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 23, 2025
Motivation as in 3f6de86; the new spec points in [1] tell us these can throw. [1] ably/specification#346
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 23, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jul 29, 2025
Based on [1] at 2963300. Have not implemented RTL04b1's channel mode checking for same reason as mentioned in 8d881e2. Have not currently tested `replaceData`'s return value; will do once [2] clarified. [1] ably/specification#346 [2] https://github.com/ably/specification/pull/346/files#r2201363446
lawrence-forooghian
approved these changes
Sep 4, 2025
VeskeR
force-pushed
the
objects-features-idl
branch
from
38a7dfa to
875d7ac
Compare
VeskeR
force-pushed
the
PUB-1827/objects-subscriptions
branch
from
2963300 to
c63992b
Compare
VeskeR
force-pushed
the
objects-features-idl
branch
from
875d7ac to
7ccb26d
Compare
Resolves PUB-1827
VeskeR
force-pushed
the
PUB-1827/objects-subscriptions
branch
from
c63992b to
46888e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PUB-1827