-
Notifications
You must be signed in to change notification settings - Fork 45
EDU-2113: Coverts Rest API page to MDX #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments after skimming through.
- The header tags need to be in html format so
<a id="" /> - Any code blocks wrapped in ``` need to be wrapped in a
- All ``` need to have a name/language with them. Even if it's just text I think.
- List such as the below need to be converted to a 3 column table:
- Content-Type := not applicable
- Accept := `application/json` by default, or `application/x-msgpack`, `text/html`
- Auth required := yes ([basic](#basic-authentication) or [token](#token-authentication))
I think this may need to be looked at with your other PR too.
3059b40 to
9627c34
Compare
a470b81 to
0a19148
Compare
ce21395 to
1e50c24
Compare
ahhh you beat ne to it ...I was going to re-tag you for review when I was done properly :). But thanks for your input as always :) |
eb3435a to
8ec0401
Compare
3ab6868 to
01a6f1e
Compare
This PR:
https://ably.com/docs/api/rest-apto MDXEDU-2113