-
Notifications
You must be signed in to change notification settings - Fork 46
Add message/client-summary endpoint docs #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: annotations-rest-api
Are you sure you want to change the base?
Add message/client-summary endpoint docs #2872
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| h3(#annotations-client-summary). Retrieve annotation summary for a specific clientId | ||
|
|
||
| h6. GET rest.ably.io/channels/@<channelId>@/messages/@<messageSerial>@/client-summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base branch likely needs rebasing as well, but I recently updated all endpoints to the new format (main.realtime.ably.net)
|
|
||
| h5. Parameters | ||
|
|
||
| - forClientId := _client1_ The clientId to retrieve the annotation summary for. It defaults to the clientId of the authenticated client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I ask why we ended up with forClientId on this endpoint? Every other rest endpoint that accepts a client id parameter uses clientId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought clientId is used for authentication, to act on behalf of the given clientId. This endpoint should allow you to fetch the summary of any client, not just yours.
I mean if you don't have access to act on behalf of another clientId you can still fetch a sliced summary for that clientId.
Description
Add client-summary endpoint docs. https://ably.atlassian.net/browse/CHA-1199
I wasn't sure how to document the response of the summary. It's the just the annotation summary, clipped, and only including the entries that are relevant for the requested clientId. Should I add an example? I just copied the text that describes the summary from the _message_annotations partial.
Checklist