-
Notifications
You must be signed in to change notification settings - Fork 45
[EDU-2104] Update endpoints from ably.io
to ably.net
#2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no objection from me but not approving as I'll leave it to Laura to confirm the endpoints are right from an infra pov
<Code> | ||
```shell | ||
curl -X POST "https://sandbox-rest.ably.io/channels/my-channel/objects" \ | ||
curl -X POST "https://sandbox-main.realtime.ably.net/channels/my-channel/objects" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sandbox uses a nonprod domain:
curl -X POST "https://sandbox-main.realtime.ably.net/channels/my-channel/objects" \ | |
curl -X POST "https://sandbox.realtime.ably-nonprod.net/channels/my-channel/objects" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good spot! I think this should actually have been pointing to main originally. eccdd53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one correction related to sandbox but otherwise looks good
Description
This PR updates the listed endpoints from
ably.io
to the new formats;realtime.ably.io
andrest.ably.io
consolidated tomain.realtime.ably.net
mqtt.ably.io
tomain.mqtt.ably.net
pusher.ably.io
andrealtime-pusher.ably.io
tomain.pusher.ably.net
pubnub.ably.io
tomain.pubnub.ably.net
Checklist