-
Notifications
You must be signed in to change notification settings - Fork 43
[EDU-1993] - Add Chat's React Native getting started guide #2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[EDU-1993] - Add Chat's React Native getting started guide #2687
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
761fe29
to
bbc1684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, but looks good!
export const ChatProviders: React.FC<{children: React.ReactNode}> = ({ | ||
children, | ||
}) => { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setup of the providers should be identical for react and react native. Could we either make this look like the base react guide, or update that one to match how you've done things here please? :)
attach={true} | ||
> | ||
<KeyboardAvoidingView | ||
style={{flex: 1}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does KeyboardAvoidingView not take tailwind in its classname props, or was it just not behaving well?
return; | ||
} | ||
|
||
room.messages.update(editingMessage.serial, {text: editText.trim()}, {description: "Message update by user"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure whats happened here, is there a reason you are using room instead of the update func exposed by the useMessage hook? :) Seems the text above suggest it's supposed to be present here?
bbc1684
to
4b44f1e
Compare
A new getting started guide for Chat in React Native using Expo.