-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/pub 1676 message annotations #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mschristensen
wants to merge
19
commits into
main
Choose a base branch
from
feature/PUB-1676-message-annotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9110e79
channels: add annotations channel rule
mschristensen 9a56e64
messages: add annotations docs
mschristensen 9076e8f
annotations: add docs for enabling annotations
mschristensen 37c3af6
annotations: publish, subscribe, summary and type
mschristensen fe6d45c
annotations: delete annotations
mschristensen 151a351
messages: call out additional annotation fields
mschristensen 124691c
pubsub: add annotations to further reading
mschristensen 7e9697c
channels: document annotation modes & capabilities
mschristensen 04d600f
annotations: (un)identified client clarifications
mschristensen 3c3b743
fixup! annotations: publish, subscribe, summary and type
mschristensen 0402c4c
fixup! annotations: delete annotations
mschristensen e91438f
fixup! annotations: publish, subscribe, summary and type
mschristensen 1067985
fixup! annotations: publish, subscribe, summary and type
mschristensen ef9bb63
annotations: add annotations error codes
mschristensen 9fa8c3e
annotations: channel rule name & mark experimental
mschristensen 847e992
annotations: restructure annotations page to split summaries and indi…
m-hulbert 0b29a4e
fixup! annotations: restructure annotations page to split summaries a…
m-hulbert 3539bc7
fixup! annotations: channel rule name & mark experimental
m-hulbert 612c0c0
fixup! annotations: add annotations error codes
m-hulbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should list the additional properties here.