Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop unnecessary implementation #44

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

i10416
Copy link

@i10416 i10416 commented Apr 12, 2023

It seems GcsArtifactRegistryUrlConnection exists only for preventing url with artifact-registry:// protocol from raising runtime error.

It seems GcsArtifactRegistryUrlConnection exists only for preventing url with
`artifact-registry://` protocol from raising runtime error.
@abdolence
Copy link
Owner

I think it is used for resolving/downloading stuff from sbt (coursier config).
Also people actually using that class in some kind of extensions, so I'd prefer not to remove functionality until I can confirm it is not used :)

@i10416
Copy link
Author

i10416 commented Apr 12, 2023

Okey. I will convert this PR back to draft.

@i10416 i10416 marked this pull request as draft April 12, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants