fix(transport): return None from Dummy.read() when no data available #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 100% CPU usage when using the Dummy transport for testing.
Problem
The Dummy transport's
read()method was returningbytearray(length)instead ofNonewhen no data is available. This causes the StreamDeck polling loop to never sleep, resulting in 100% CPU usage.Solution
Changed
Dummy.Device.read()to returnNonewhen no data is available, matching the behavior ofLibUSBHIDAPIwhich returnsNonewhenhid_read()returns 0.Verification
Run this script to verify the fix (watch CPU usage - without the fix it spins at 100%):