Feature/push channel support #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamWaghmare-sap
requested changes
May 21, 2025
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPull.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPull.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPull.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPull.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPull.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPull.java
Outdated
Show resolved
Hide resolved
| } catch (Exception e) { | ||
| Display.getDefault().asyncExec(() -> { | ||
| Shell shell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell(); | ||
| MessageDialog.openError(shell, "Error", e.getMessage()); //$NON-NLS-1$ |
There was a problem hiding this comment.
Same comment like in AbapGitWizardPull class.
Can reuse the title here.
| try { | ||
| getContainer().run(true, true, new IRunnableWithProgress() { | ||
| Job pullJob = new Job("Pull Repository"){ //$NON-NLS-1$ |
There was a problem hiding this comment.
Same comment like in AbapGitWizardPull class.
Can reuse the title here
Comment on lines
83
to
84
| Set<IRepositoryModifiedObjects> pageOverwriteObjects = this.pageOverwriteObjectsSelection.getSelectedObjects(); | ||
| Set<IRepositoryModifiedObjects> pagePackageWarningObjects = this.pagePackageWarningObjectsSelection.getSelectedObjects(); |
There was a problem hiding this comment.
Same comment like in AbapGitWizardPull class.
Can rename the variable names.
| return Status.OK_STATUS; | ||
|
|
||
| } catch (ResourceException e) { | ||
| showErrorMessage(e.getMessage()); |
There was a problem hiding this comment.
I don't think we need to show the error message explicitly.
It will be taken care of by the Jobs API, once we return the Error Status, like you have done in line 192.
Comment on lines
188
to
189
| return Status.OK_STATUS; | ||
|
|
There was a problem hiding this comment.
Can we refresh the repositories view after the job is finished ?
I am not very sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push Channel Support for long running jobs:
Backlog link : https://jira.tools.sap/browse/ADTIRA-1494
Changes Made: