Aavegotchi bridge (Polygon <> Gotchichain)#203
Open
KevinKons wants to merge 42 commits intoaavegotchi:SOLID-135-prepare-gotchichain-deploy-scriptfrom
Open
Aavegotchi bridge (Polygon <> Gotchichain)#203KevinKons wants to merge 42 commits intoaavegotchi:SOLID-135-prepare-gotchichain-deploy-scriptfrom
KevinKons wants to merge 42 commits intoaavegotchi:SOLID-135-prepare-gotchichain-deploy-scriptfrom
Conversation
andborges
reviewed
Jun 14, 2023
KevinKons
commented
Jun 20, 2023
KevinKons
commented
Jun 21, 2023
KevinKons
changed the title
web3rover
reviewed
Jun 28, 2023
orionstardust
suggested changes
Jun 29, 2023
web3rover
reviewed
Jun 29, 2023
orionstardust
suggested changes
Jun 30, 2023
Author
|
@orionstardust Can we have an estimate on when you will be done deploying the contracts? |
web3rover
changed the base branch from
SOLID-135-prepare-gotchichain-deploy-script
to
gotchichain
web3rover
changed the base branch from
gotchichain
to
SOLID-135-prepare-gotchichain-deploy-script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the bridge implementation of Aavegotchis and Items.
BridgeGotchichainSide and BridgePolygonSide are the contracts responsible for handling the bridge of aavegotchi. These contracts extends contracts implemented by LayerZero that we are using as base for our bridge.
The ItemsBridgePolygonSide and ItemsBridgeGotchichainSide are basically the same thing as the above, but we use then to implement the Items bridge.
We have two test files, aavegotchiBridge.test.ts and itemsBridge.test.ts. These files use an mocked implementation of LayerZero that allows for testing the bridge in only one chain.
The most important part that we need you to review is the way we are handling the manipulation of items and aavegotgchis on the PolygonXGotchichainBridgeFacet contract. This contract basically handles updating Aavegotchis metadata and updating items ownership when we bridge them.