Skip to content

Fix ERC721 listing price updates#40

Open
cinnabarhorse wants to merge 2 commits intomasterfrom
codex/fix-erc721-listing-price-update
Open

Fix ERC721 listing price updates#40
cinnabarhorse wants to merge 2 commits intomasterfrom
codex/fix-erc721-listing-price-update

Conversation

@cinnabarhorse
Copy link
Member

Fixes to persist the new price in storage (it was previously only emitting an event).

Impact:

  • Sellers can actually update listing prices.
  • Buyers can no longer purchase at the stale/old price after an update.

Tests:

  • /Users/coderdan/Documents/GitHub/aavegotchi-geist
    /Users/coderdan/Documents/GitHub/aavegotchi-geist
    Nothing to compile
    No need to generate any newer typings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant