AGIP135: add batch equip functions for wearables and wearable configs#3
Open
pgendreau wants to merge 8 commits intoaavegotchi:masterfrom
Open
AGIP135: add batch equip functions for wearables and wearable configs#3pgendreau wants to merge 8 commits intoaavegotchi:masterfrom
pgendreau wants to merge 8 commits intoaavegotchi:masterfrom
Conversation
…arables and upgrade script for ItemsFacet
pgendreau
changed the title
|
|
||
| // if the sender is not the owner and the gotchi has been bridged | ||
| // then they need to pay a fee to the owner | ||
| if (sender != owner) { |
Member
There was a problem hiding this comment.
It seems like it's possible for someone other than the owner to update an existing config ID, is that the intended behavior? @pgendreau
Author
There was a problem hiding this comment.
It's so it can be delegated but I see how this could be used maliciously when updating someone else configuration without a proper permission system. We could remove it for update and leave it for createWearablesConfig as it is not as problematic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.