feat: Use latestAnswer instead of latestRoundData for reserve price on AaveOracle #1221
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "getUserAccountData: supplies: 0, borrows: 0": "13014", | ||
| "getUserAccountData: supplies: 1, borrows: 0": "49057", | ||
| "getUserAccountData: supplies: 2, borrows: 0": "80364", | ||
| "getUserAccountData: supplies: 2, borrows: 1": "100347", | ||
| "getUserAccountData: supplies: 2, borrows: 2": "119238" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| // Imported from https://github.com/smartcontractkit/chainlink/blob/e8490e910274279a2c394ba37eb328943322ac6b/contracts/src/v0.8/shared/interfaces/AggregatorInterface.sol | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| // solhint-disable-next-line interface-starts-with-i | ||
| interface AggregatorInterface { | ||
| function latestAnswer() external view returns (int256); | ||
|
|
||
| function latestTimestamp() external view returns (uint256); | ||
|
|
||
| function latestRound() external view returns (uint256); | ||
|
|
||
| function getAnswer(uint256 roundId) external view returns (int256); | ||
|
|
||
| function getTimestamp(uint256 roundId) external view returns (uint256); | ||
|
|
||
| event AnswerUpdated(int256 indexed current, uint256 indexed roundId, uint256 updatedAt); | ||
|
|
||
| event NewRound(uint256 indexed roundId, address indexed startedBy, uint256 startedAt); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| // Imported from https://github.com/smartcontractkit/chainlink/blob/e8490e910274279a2c394ba37eb328943322ac6b/contracts/src/v0.8/shared/interfaces/AggregatorV2V3Interface.sol | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| import {AggregatorInterface} from "./AggregatorInterface.sol"; | ||
| import {AggregatorV3Interface} from "./AggregatorV3Interface.sol"; | ||
|
|
||
| // solhint-disable-next-line interface-starts-with-i | ||
| interface AggregatorV2V3Interface is AggregatorInterface, AggregatorV3Interface {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,9 +2,9 @@ | |||||||||
| // Copyright (c) 2025 Aave Labs | ||||||||||
| pragma solidity ^0.8.0; | ||||||||||
|
|
||||||||||
| import {AggregatorV2V3Interface} from 'src/dependencies/chainlink/AggregatorV2V3Interface.sol'; | ||||||||||
|
|
||||||||||
| contract MockPriceFeed is AggregatorV2V3Interface { | ||||||||||
| uint8 public immutable override decimals; | ||||||||||
| string public override description; | ||||||||||
|
|
||||||||||
|
|
@@ -47,4 +47,24 @@ contract MockPriceFeed is AggregatorV3Interface { | |||||||||
| updatedAt = block.timestamp; | ||||||||||
| answeredInRound = roundId; | ||||||||||
| } | ||||||||||
|
|
||||||||||
| function latestAnswer() external view override returns (int256) { | ||||||||||
| return _price; | ||||||||||
| } | ||||||||||
|
|
||||||||||
| function latestTimestamp() external view override returns (uint256) { | ||||||||||
| return block.timestamp; | ||||||||||
| } | ||||||||||
|
|
||||||||||
| function latestRound() external view override returns (uint256) { | ||||||||||
| return block.timestamp; | ||||||||||
| } | ||||||||||
|
|
||||||||||
| function getAnswer(uint256) external view override returns (int256) { | ||||||||||
|
There was a problem hiding this comment. The getAnswer function ignores the roundId parameter and always returns the current price. According to the Chainlink AggregatorInterface specification, getAnswer should return historical answers based on the roundId. This implementation is inconsistent with UnitPriceFeed.getAnswer which does check the roundId parameter. Consider either documenting this deviation from the standard interface behavior or implementing historical round tracking if accurate behavior is required.
Suggested change
|
||||||||||
| return _price; | ||||||||||
| } | ||||||||||
|
|
||||||||||
| function getTimestamp(uint256) external view override returns (uint256) { | ||||||||||
| return block.timestamp; | ||||||||||
|
Comment on lines
+67
to
+68
There was a problem hiding this comment. The getTimestamp function ignores the roundId parameter and always returns the current block.timestamp. According to the Chainlink AggregatorInterface specification, getTimestamp should return the timestamp of a specific round. This implementation is inconsistent with UnitPriceFeed.getTimestamp which does check the roundId parameter. Consider either documenting this deviation from the standard interface behavior or implementing historical round tracking if accurate behavior is required.
Suggested change
|
||||||||||
| } | ||||||||||
| } | ||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imports AggregatorV3Interface and AggregatorInterface are redundant since AggregatorV2V3Interface already extends both of these interfaces. Consider removing these imports to keep the code clean and reduce unnecessary dependencies.