gas analysis: Single reserve event emission for dynamic config update#1168
Draft
CheyenneAtapour wants to merge 11 commits intodevfrom
Draft
gas analysis: Single reserve event emission for dynamic config update#1168CheyenneAtapour wants to merge 11 commits intodevfrom
CheyenneAtapour wants to merge 11 commits intodevfrom
Conversation
yan-man
reviewed
Jan 31, 2026
|
|
||
| /// @notice Emitted when a user's dynamic config is refreshed for a single reserve to its latest config key. | ||
| /// @param user The address of the user. | ||
| /// @param reserveId The identifier of the reserve. |
Contributor
There was a problem hiding this comment.
i think we should rename this, no need for single. like RefreshUserDynamicConfig
yan-man
reviewed
Jan 31, 2026
| accountData.activeCollateralCount = accountData.activeCollateralCount.uncheckedAdd(1); | ||
| } | ||
| } | ||
| if (refreshConfig) { |
Contributor
There was a problem hiding this comment.
wonder if it is worth moving up to L740 and combining the logic with the collFactor
anyway stermi had mentioned having the ternary op there was hard to read
yan-man
reviewed
Jan 31, 2026
| // Liquidate alice | ||
| vm.prank(bob); | ||
| spoke.liquidationCall(collateralReserveId, debtReserveId, alice, 1e18, false); | ||
| vm.snapshotGasLastCall(NAMESPACE, 'L. liquidateUser: 2 collaterals'); |
Contributor
There was a problem hiding this comment.
think these all should be liquidationCall rather than liquidateUser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.