Skip to content

feat: harness-aware doctor planning process#935

Draft
a5c-ai[bot] wants to merge 3 commits into
stagingfrom
plan/issue-877
Draft

feat: harness-aware doctor planning process#935
a5c-ai[bot] wants to merge 3 commits into
stagingfrom
plan/issue-877

Conversation

@a5c-ai

@a5c-ai a5c-ai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Links #877\n\n## Summary\n- Adds a Babysitter process definition for implementing harness-aware doctor behavior for issue #877.\n- Adds matching concrete inputs for the issue, target files, acceptance criteria, and verification commands.\n- Keeps the process scoped to planning, implementation orchestration, verification, review, and delivery without adding source implementation changes.\n\n## Planned Phases\n- Read issue #877 and preserve triage requirements.\n- Run Phase 0 reuse audit across doctor guidance, SDK command templates, harness capability APIs, generated plugin surfaces, and tests.\n- Trace canonical doctor source propagation and StopHook/non-StopHook capability APIs.\n- Author regression coverage for neutral N/A behavior on non-StopHook harnesses.\n- Design and implement the harness-aware doctor update through the unified source and generated sync path.\n- Iterate verification and review up to three attempts.\n- Deliver an implementation PR only after final acceptance passes.\n\n## Quality Gates\n- Non-StopHook harnesses, especially Pi, must report section 10 as neutral N/A instead of FAIL when Claude hook files are absent.\n- N/A must not contribute to WARNING or CRITICAL verdicts.\n- Claude Code and other StopHook harness diagnostics must remain actionable.\n- Generated SDK and plugin doctor surfaces must stay synchronized from the unified command source.\n- Verification commands include check:sdk-command-templates, generate:plugins, build:sdk, test:sdk, verify:metadata, and git diff --check.

@a5c-ai

a5c-ai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Author

Implemented the planned harness-aware doctor changes on plan/issue-877.

Summary:

  • Updated the canonical doctor command to run Phase 0 harness capability detection using SDK-owned harness APIs (detectCallerHarness, getAdapterByName, getCapabilities, supportsHookType).
  • Gated Section 10 StopHook diagnostics so non-StopHook harnesses report neutral N/A instead of failing on missing Claude hook files.
  • Made N/A neutral in final health scoring and recommendations, and kept Claude-only remediation conditional on claude-code.
  • Synced the generated SDK doctor command template and added a focused regression test for the doctor command template.
  • Included the required SDK command-template sync update for the stale blueprints command template.

Verification passed:

  • npm run check:sdk-command-templates
  • npm run generate:plugins
  • npm run build:sdk
  • npm run test:sdk (2075 passed, 9 skipped)
  • npm run verify:metadata
  • git diff --check

Pushed commit: d943cee04 Fix harness-aware doctor hook diagnostics.

@a5c-ai

a5c-ai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Author

Implemented the planned harness-aware doctor changes on plan/issue-877.

Summary:

  • Added Phase 0 harness capability detection to the canonical doctor command using SDK-owned harness truth (detectCallerHarness, getAdapterByName, getCapabilities, and supportsHookType('stop')).
  • Gated section 10 hook execution health on StopHook support; non-StopHook harnesses such as Pi now report neutral N/A instead of failing on missing Claude hook files/settings.
  • Updated final health scoring so N/A does not contribute to WARNING or CRITICAL, and made Claude-only remediation/debug guidance conditional on claude-code.
  • Synced the generated SDK command template and added prompt regression coverage for StopHook gating, neutral N/A, and Claude-only remediation.

Verification:

  • npm run check:sdk-command-templates passed.
  • npm run generate:plugins completed with existing target warnings and no failures.
  • npm run build:sdk passed.
  • npm run test:sdk passed on rerun: 147 files passed, 1 skipped; 2075 tests passed, 9 skipped. The first full run hit a transient JSON parse failure in runHarness.test.ts, and the isolated test plus full rerun passed.
  • npm run verify:metadata passed.
  • git diff --check passed.

Push status: origin/plan/issue-877 is up to date.

@tmuskal

tmuskal commented Jun 5, 2026

Copy link
Copy Markdown
Member

very bad implementation that doesn't go through extension adapter . also, no need to change the blueprints command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants