-
Notifications
You must be signed in to change notification settings - Fork 96
feat: update grpc-java to the newer version; handle introduced StatusException #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @anFatum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical dependency update, upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully updates the grpc-java library to version 1.77.0 and correctly handles the newly introduced StatusException in the GrpcTransport and A2AServiceGrpc classes. The pom.xml update reflects the version change. The changes are well-contained and address the stated goal of the PR. One minor documentation update is suggested for clarity.
client/transport/grpc/src/main/java/io/a2a/client/transport/grpc/GrpcErrorMapper.java
Outdated
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates grpc-java to version 1.77.0 and adapts the codebase to handle the StatusException introduced in blocking calls. The changes are well-executed: the POM file is updated, the generated gRPC stub reflects the new exception signatures, GrpcTransport correctly catches both StatusRuntimeException and StatusException for blocking calls, and GrpcErrorMapper is appropriately generalized to handle any Throwable. The implementation is solid and addresses the core requirements of the library upgrade. I've included one suggestion to improve the maintainability of the error mapping logic.
|
Hi @anFatum we're currently working on a big refactoring touching gRPC. We will give your PR attention once that is in. Thanks! |
|
Thank you @kabir for an update! |
|
@anFatum Could you please rebase your changes |
Description
Update the grpc-java used to the latest available release - 1.77. It introduces the StatusException on the BlockingClientCall, add adjustments for this case as well.
I've run the tests and they all finished successfully:
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕