Update getFolders() method name, added recursion feature #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks a lot for this cool lib 👍
I was trying to list all content of a directory and everything I found was the
getFolders()method, so I thought the library doesn't provide the feature of listing everything yet... so I had a look at Sardine to find out thatgetFolders()already does exactly what I need :)I marked
getFolders()as deprecated and addedlistFolderContent()with a javadoc that is a bit clearer in my opinion.Additionally there's now the possibility to provide a
depthparameter to list file names and subfolders also recursively.EDIT: Argh, just saw that I accidentally committed some formatting changes also, sorry :(. Please let me know if I should revert them in case you want to merge this PR