fix(lsp): file incorrectly updated when importing modules, fixes #135 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of incorrectly identifying an import statement
… part of the name
* fixed autoimport for other completion kinds that require import * Apply suggestions from code review remove unused parameter Co-authored-by: Adrian Hesketh <[email protected]> * Apply suggestions from code review fix naming typo Co-authored-by: Adrian Hesketh <[email protected]> * changed how a kind that requires import is identified * remove obsolete regexp --------- Co-authored-by: agalbenus <[email protected]> Co-authored-by: Adrian Hesketh <[email protected]>
a-h
added a commit
that referenced
this pull request
Sep 24, 2023
…#136) * fix(lsp): file incorrectly updated when importing modules, fixes #135 * refactor: reduce time spent iterating through files, and reduce risk of incorrectly identifying an import statement * refactor: add tests for import management * refactor: rename field * fix: use the detail section, because the label only includes the last part of the name * fix: solve auto-import for completions that require them (#138) * fixed autoimport for other completion kinds that require import * Apply suggestions from code review remove unused parameter Co-authored-by: Adrian Hesketh <[email protected]> * Apply suggestions from code review fix naming typo Co-authored-by: Adrian Hesketh <[email protected]> * changed how a kind that requires import is identified * remove obsolete regexp --------- Co-authored-by: agalbenus <[email protected]> Co-authored-by: Adrian Hesketh <[email protected]> * refactor: minor restructure, and additional test --------- Co-authored-by: Adrian Galbenus <[email protected]> Co-authored-by: agalbenus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.