Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update generated code to return nil instead of generated value #1012

Closed
wants to merge 1 commit into from

Conversation

guilhas07
Copy link
Contributor

@guilhas07 guilhas07 commented Dec 8, 2024

I believe this is enough to solve #991. Let me know if I missed something!

Closes #991

@guilhas07 guilhas07 force-pushed the main branch 4 times, most recently from 5f29086 to 8053d67 Compare December 8, 2024 17:01
@guilhas07 guilhas07 changed the title chore: update generated code to ruturn nil instead of generated value chore: update generated code to return nil instead of generated value Dec 8, 2024
@a-h
Copy link
Owner

a-h commented Dec 27, 2024

I haven't merged this because I haven't been able to check out the branch and test it.

0 0 /Users/adrian/github.com/a-h/templ % gh pr checkout 1012
From github.com:a-h/templ
 ! [rejected]        refs/pull/1012/head -> guilhas07/main  (non-fast-forward)
failed to run git: exit status 1

Not sure what's going on with that. I'll try to do a cherry pick for the main file so you get "contributor" status.

@a-h
Copy link
Owner

a-h commented Dec 27, 2024

Merged in #1025 - I cherry picked your commit etc.

@a-h a-h closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: update generated code to return nil instead of a nil value
2 participants