-
Notifications
You must be signed in to change notification settings - Fork 268
fix(openrouter): profile moonshotai/kimi-k3 with truthful max_tokens and reasoning effort #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
easonLiangWorldedtech
wants to merge
8
commits into
Zoo-Code-Org:main
Choose a base branch
from
easonLiangWorldedtech:fix/issue-1316-openrouter-kimi-k3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+333
−3
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0b38812
fix(openrouter): profile moonshotai/kimi-k3 with truthful max_tokens …
easonliang28 619915c
Merge branch 'main' into fix/issue-1316-openrouter-kimi-k3
easonLiangWorldedtech 57d2cc5
Merge branch 'main' into fix/issue-1316-openrouter-kimi-k3
easonLiangWorldedtech 6641383
fix(openrouter): address PR 1325 review feedback for Kimi K3
easonliang28 1492cc5
Merge branch 'main' into fix/issue-1316-openrouter-kimi-k3
easonLiangWorldedtech ad148b1
Merge branch 'main' into fix/issue-1316-openrouter-kimi-k3
easonliang28 fb30c8d
Keep Moonshot K3 profile literals inside applyOpenRouterMoonshotK3Pro…
easonliang28 6108884
fix(openrouter): match the tilde-prefixed OpenRouter Kimi alias id
easonliang28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
new Setgets allocated on every non-K3 call (before the early-return). The same file uses an||comparison for the equivalent 2-model guard at line 265 — wouldif (modelId !== "moonshotai/kimi-k3" && modelId !== "~moonshotai/kimi-latest")work here too, satisfying the same mutation-testing constraint with no allocation?