[Feat] Add a persisted opt-in setting for DCG

[navedmerchant]

Related GitHub Issue

Closes #1057
Part of #1049. Split from #1050.

Description

Adds the persisted destructiveCommandGuardEnabled setting across shared types, extension/provider state, SettingsView's local cached state, save handling, and Auto-Approve settings UI.

Enabling verifies DCG installation. Failure normalizes the setting back to disabled and shows a localized error. Existing allowlist/denylist behavior remains available while DCG is disabled. This PR does not yet change command approval policy.

Stack

3 / 4 — base: feat/dcg-binary-service

Depends on PR 2 only for enable-time installation verification.

Test Procedure

pnpm --dir src exec vitest run core/webview/__tests__/ClineProvider.spec.ts core/webview/__tests__/webviewMessageHandler.spec.ts
pnpm --dir webview-ui exec vitest run src/components/settings/__tests__/AutoApproveSettings.spec.tsx
pnpm --dir packages/types check-types
pnpm --dir src check-types
pnpm --dir webview-ui check-types
node scripts/find-missing-translations.js --area=core
node scripts/find-missing-translations.js --area=webview

Result: 183 extension and 11 webview tests passed; all type-checks, lint, and translation validation passed.

Checklist

• Full setting round trip implemented
• SettingsView uses local cached state
• Tests/type-check/lint/i18n checks passing

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 44fb207d-4a45-490a-8e58-213d5681c989

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ui/src/components/settings/AutoApproveSettings.tsx	68.42%	0 Missing and 6 partials ⚠️
src/core/webview/ClineProvider.ts	50.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[edelauna]

looks good - mostly minor nits

[edelauna]

When !binaryPath, the already-localized unavailable message gets thrown, caught, and re-interpolated into this wrapper — so the user sees "Unable to enable Destructive Command Guard: Destructive Command Guard is enabled but is not available for this platform". Should the !binaryPath branch just call showErrorMessage directly instead of routing through this generic wrapper?

[edelauna]

This sits right next to destructiveCommandGuard.unavailable (nested camelCase) but uses flat snake_case — any reason not to keep both keys under the same destructiveCommandGuard namespace?