feat(_release-rust): opt-in GCP-KMS code signing - #97
Merged
Conversation
…rgo-xwin) Opt-in signing (default off). Binaries are signed before packaging: - macOS: rcodesign + notarize; Apple creds from GCP Secret Manager via CODESIGN_*. - Windows: Authenticode (jsign + GCP KMS) on the Linux cross-build runner; x64+arm64. - Linux: TWO detached OpenPGP sigs (kunobi-pgp-kms) — the ELF (.asc bundled inside the tarball) AND the .tar.gz archive (.asc uploaded as a release asset). Adds id-token: write and signing secrets (no Apple secrets).
TEMPORARY — revert to @v1.2.0 before merging (immutable tag). Lets the whole signing chain compose off the unmerged feat/code-signing branches.
emmanuelm41
force-pushed
the
feat/code-signing
branch
from
June 18, 2026 14:44
610895e to
8cecdf5
Compare
The 'secrets' context can't be referenced in a reusable-workflow 'with:', so callers (esp. public repos that keep config as secrets) couldn't pass CODESIGN_*/PGP_SIGN_*. Move those 9 from inputs to the secrets: block and reference them as secrets.* in the build job.
actions PR #12 merged and tagged v1.2.0 / v1, so promote the signing composite action refs from the test branch to the released major tag.
emmanuelm41
marked this pull request as ready for review
June 18, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — part 2 of a 3-repo code-signing rollout. Depends on
Zondax/actionsPR #12 (references its actions at@v1.2.0).What
Adds opt-in OS code signing to
_release-rust.yml, default off (no change for existing callers):id-token: writeadded to the workflow's own top-levelpermissions:(the ceiling — callers can't grant it otherwise).enable_signing,notarize_macos, Apple/CODESIGN/PGP config,jsign_sha256,rcodesign_sha256) and signingsecrets:.buildjob: sign macOS (rcodesign) + Windows (jsign/KMS) before Package; sign the Linux archive (.asc) after Package; upload the.asc.gcp-wif-auth@v1.2.0withtoken_format: access_token,create_credentials_file:false,setup_gcloud:false,verify_authentication:false(token-only).Rollout / dependency
Zondax/actionsAdds reusable workflows for Cloud Run #12 → tagv1.2.0.v10(carriesrunner_windowsfeat(release-rust): opt-in native Windows runner for real -msvc builds #93 + signing).kunobi-ninja/kachebumps to_workflows@v10.Notes
actionlintclean (only pre-existing SC2086/SC2129 warnings).kunobi-ninja/kache, tag-push only) before any real signed run — infra prerequisite, not in this PR.